Closed angeloashmore closed 2 years ago
Merging #46 (930a668) into master (5b4d5e5) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #46 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 1768 1766 -2
Branches 7 7
=========================================
- Hits 1768 1766 -2
Impacted Files | Coverage Δ | |
---|---|---|
src/fields.ts | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Types of changes
Description
This PR simplifies
ImageField
by changing how it uses handlesThumbnailNames
when givennull
as its value.Deprecating
null
inThumbnailNames
As of this PR,
ImageField<never>
is the preferred method to type an Image field without thumbnails.ImageField<null>
will continue to work, butnull
is now depreacted.Reason for the change
@prismicio/helpers
's use ofImageField
in itsisFilled.image()
helper resulted in a brokenindex.d.ts
file in@prismicio/helpers
. The compiled type declaration file, bundled byrollup-plugin-dts
, included invalid types.See the following issues for more details:
The simplification made in this PR removes the invalid generated code in
@prismicio/helpers
and@prismicio/client
.Checklist:
🐻❄️