Closed lihbr closed 2 years ago
Merging #47 (bc7d242) into master (bb88ccd) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 4 7 +3
Lines 1774 1614 -160
Branches 7 6 -1
==========================================
- Hits 1774 1614 -160
Impacted Files | Coverage Δ | |
---|---|---|
src/fields/embed.ts | 100.00% <100.00%> (ø) |
|
src/fields/index.ts | 100.00% <100.00%> (ø) |
|
src/fields/link.ts | 100.00% <100.00%> (ø) |
|
src/fields/richText.ts | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Looking good to me, but I'll wait for your green mark :)
Looks great! Merging & deploying.
Types of changes
Description
Refactor the really long type definition files into multiple, smaller ones, for readability.
customTypeModelFields
andfields
(apart from deprecated models)CustomTypeModel
lives in its own files at root, as it's the analog ofPrismicDocument
Any comment/improvement suggestions on this logic? I really think it eases readability and maintainability when split into multiple files like this.
Checklist: