prismicio / prismic-types

Type definitions for Prismic content, models, and APIs
https://prismic.io/docs/technologies/javascript
Apache License 2.0
11 stars 4 forks source link

refactor: organize types by kind #47

Closed lihbr closed 2 years ago

lihbr commented 2 years ago

Types of changes

Description

Refactor the really long type definition files into multiple, smaller ones, for readability.

Any comment/improvement suggestions on this logic? I really think it eases readability and maintainability when split into multiple files like this.

Checklist:

🦎
codecov-commenter commented 2 years ago

Codecov Report

Merging #47 (bc7d242) into master (bb88ccd) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master       #47    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            4         7     +3     
  Lines         1774      1614   -160     
  Branches         7         6     -1     
==========================================
- Hits          1774      1614   -160     
Impacted Files Coverage Δ
src/fields/embed.ts 100.00% <100.00%> (ø)
src/fields/index.ts 100.00% <100.00%> (ø)
src/fields/link.ts 100.00% <100.00%> (ø)
src/fields/richText.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lihbr commented 2 years ago

Looking good to me, but I'll wait for your green mark :)

angeloashmore commented 2 years ago

Looks great! Merging & deploying.