search

prismicio / prismic-vue

Vue plugin, components, and composables to fetch and present Prismic content
https://prismic.io/docs/technologies/vuejs
Apache License 2.0
65 stars 16 forks source link

noreferrer for external links #38

Closed Kunsih6 closed 3 years ago

Kunsih6 commented 3 years ago

Hello there!

I've noticed that the external links didn't include the attribute rel = "noreferrer" which is considered a good practice to avoid security and performance issues. More info about it here.

I'll create a PR that adds the attribute.

Thanks for your hard work!

lihbr commented 3 years ago

Hey @Kunsih6 thank you so much for your contributions!

We'll consider making the switch from noopener to noreferrer as it may have some unwanted side-effects for some users, not sure.

Also according to the documentation since noreferrer is a stronger alternative to noopener (also covering the window.opener case) it might not be needed to add both of them here: https://github.com/Kunsih6/prismic-vue/blob/master/src/components/Link.js#L44

lihbr commented 3 years ago

Hey, just leaving an update here, I still have this issue at the back of my mind, we'll consider it when working on our Vue 3 kit I think 🙂

lihbr commented 3 years ago

Hey @Kunsih6,

We discussed again this change with the team and ended up considering the performance issue was already handled by the noopener attribute value and that changing it to noreferrer might lead to some unexpected side effects. Therefore we might not change that value for this version of the kit.

We'll consider a way for people to pick their link strategy in the next major of this kit. Regarding that, we'll have RFCs and suggestion issues opened soon!

We're closing this issue and your PR for now but we're happy to reopen the discussion if you want to. Thank you so much for your interest in Prismic and willingness to contribute!