prismicio / ruby-rails-starter

Starter project for Ruby on Rails – Works with any prismic.io repository
32 stars 21 forks source link

Setting the prismic.io OAuth actions in their own controller #9

Closed rudyrigot closed 10 years ago

rudyrigot commented 10 years ago

I'm not sure about best practice on how to segment controllers, but these actions hanging out in the same controller where work is supposed to get done are just really annoying, and make the controller harder to maintain for no reason. Does it sound ok on a "controller best practice" point of view to make them live their own lives in their own controller?

dohzya commented 10 years ago

To be honest I think we should have made this split sooner ;-)

Thanks!

rudyrigot commented 10 years ago

Cool! :)

I reflected the change on all the ongoing Rails examples.