prismicio / slice-machine

A series of tools for developing and deploying website sections with Prismic
https://prismic.io/docs
Apache License 2.0
287 stars 53 forks source link

essential-slices components don't transpile with NextJS setup #49

Closed jakeFeldman closed 3 years ago

jakeFeldman commented 4 years ago

Version

Reproduction

Following the Quick Start Guide

What is expected?

SliceMachine components to load.

What is actually happening?

Application is not able to transpile components from essential-slices pkg

image

Any additional information

Seems like the next-transpile-modules pkg is not working. I tried various versions of nextjs to see if there was a compatibility issue between the two libs but each test ended with the same results.

hypervillain commented 4 years ago

I created a PR that adds essential-slices to the list of transpiled modules here: https://github.com/prismicio/slice-machine/pull/47 and it seemed to fix the loader issue. Can you confirm that applying the fix doesn't work on your side?

jakeFeldman commented 4 years ago

@hypervillain Thanks for the quick reply! I'll give this a try and get back to you ASAP!

jakeFeldman commented 4 years ago

@hypervillain Adding 'essential-slices' to the list of pkgs to transpile inside the next.config.js resolved the issue. Thank you for the help with this! Looking forward to trying out slice machine!

lihbr commented 3 years ago

PR Merged, closing. Thanks for your input Jake!