It is not possible to save an image thumb with just a width or height - Githubissues

prismicio / slice-machine

A series of tools for developing and deploying website sections with Prismic

https://prismic.io/docs

Apache License 2.0

287 stars 53 forks source link

It is not possible to save an image thumb with just a width or height #594

Closed aynzad closed 2 years ago

aynzad commented 2 years ago

Versions

slice-machine-ui: 0.4.2
node: v14.19.3

Reproduction

using prismicio-community/nextjs-starter-prismic-blog as sample project

Steps to reproduce

npx degit prismicio-community/nextjs-starter-prismic-blog your-project-name
cd your-project-name
npm i
npx @slicemachine/init
npm run dev

Go to http://localhost:9999/slices/Image/default
Click on Edit icon of the Image row
Add a new Responsive views
Input a name and width and left height empty
Click on Save button

What is expected?

to save (500xauto) and (autox500) image thumbnails without any problems, like the legacy editor.

What is actually happening?

The save button doesn't work, Can't save the image setting that with just a fixed width or height thumbnail

Screen Shot 2022-09-17 at 11 28 27

Screen Shot 2022-09-17 at 11 27 54

angeloashmore commented 2 years ago

Form validation was incorrect. The new validation function checks for the following:

A name is required.
Only one of width or height is required. Both can be provided as well.

For the fix, see PR #601

pavery007 commented 2 years ago

Fix released to Production (SM version 0.5.1)