search

prismicio / slice-machine

A series of tools for developing and deploying website sections with Prismic
https://prismic.io/docs
Apache License 2.0
287 stars 53 forks source link

jpeg screenshots does not seem to be moved with migration #969

Closed chamois-d-or closed 1 year ago

chamois-d-or commented 1 year ago

I could not understand why only some of my screenshots were moved with the update from 0.7.0 and not the others, I'm under the impression that png are moved but not jpeg files. I then see the screenshots as missing.

image

Versions

Reproduction

migrate to 1.0.3 from 0.7.0 with png and jpeg screenshots

Steps to reproduce

What is expected?

all screenshots are moved

What is actually happening?

only png will be moved.

mdeclercq commented 1 year ago

Hi @chamois-d-or, Thanks for reporting. Indeed jpegs were missed in the migration. We created a ticket internally to handle this use case - DT-1304.

hypervillain commented 1 year ago

Non png extensions are not supported anymore by the new plugins architecture, these files are not considered valid (and therefore not moved). Would you consider it ok to update these files to png format and move them manually?

chamois-d-or commented 1 year ago

@hypervillain, yes that's exactly what I did, I renamed the files to .png and moved them manually.

hypervillain commented 1 year ago

Awesome. Feel free to reopen if needed