prismicio / slice-simulator

Preview and develop Prismic slices fast with minimal configuration

6 stars 5 forks source link

fix: remove `const enum` patterns, enable `isolatedModules` option #11

Closed jeremytenjo closed 2 years ago

jeremytenjo commented 2 years ago

Types of changes

[ ] Chore (a non-breaking change which is related to package maintenance)
[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Removed const from StateManagerStatus and added isolatedModules to true

Nextjs depends on isolatedModules set to true and builds fail in the current version

resolves https://github.com/prismicio/slice-simulator/issues/10

Checklist:

[ ] My change requires an update to the official documentation.
[x] All TSDoc comments are up-to-date and new ones have been added where necessary.
[x] All new and existing tests are passing.

jeremytenjo commented 2 years ago

Hi @lihbr, please let me know if I can provide more information in order to get this PR approved and published :)

codecov-commenter commented 2 years ago

Codecov Report

Merging #11 (4325684) into master (16a0a14) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files          27       27           
  Lines         618      618           
  Branches      113      113           
=======================================
  Hits          396      396           
  Misses        222      222

Impacted Files	Coverage Δ
packages/core/src/types.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16a0a14...4325684. Read the comment docs.

lihbr commented 2 years ago

Released in @prismicio/slice-simulator-core@0.2.3, running npm update @prismicio/slice-simulator-core in your project should fix the build issue. Let us know if you still encounter issues 🙏

jeremytenjo commented 2 years ago

No problem, thank you for the quick feedback!