Closed lihbr closed 1 year ago
Merging #14 (04a6815) into master (d6d637b) will increase coverage by
22.35%
. The diff coverage is55.64%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #14 +/- ##
===========================================
+ Coverage 63.94% 86.30% +22.35%
===========================================
Files 28 22 -6
Lines 624 1920 +1296
Branches 115 128 +13
===========================================
+ Hits 399 1657 +1258
- Misses 224 263 +39
+ Partials 1 0 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/channel/index.ts | 100.00% <ø> (ø) |
|
src/kit/eventHandlers.ts | 100.00% <ø> (ø) |
|
src/lib/EventEmitter.ts | 100.00% <ø> (ø) |
|
src/kit/SimulatorManager.ts | 16.66% <16.66%> (ø) |
|
src/kit/State.ts | 18.58% <18.58%> (ø) |
|
src/kit/domHelpers.ts | 94.66% <50.00%> (ø) |
|
src/SimulatorClient.ts | 97.77% <90.90%> (ø) |
|
src/SimulatorAPI.ts | 100.00% <100.00%> (ø) |
|
src/channel/ChannelEmitter.ts | 100.00% <100.00%> (ø) |
|
src/channel/ChannelNetwork.ts | 100.00% <100.00%> (ø) |
|
... and 12 more |
Types of changes
Description
This PR refactors the Slice simulator monorepo into a regular repository. It moves things around.
All Slice simulator initial framework-specific implementation have now moved to their respective adapter:
@prismicio/slice-simulator-react
is now available through@slicemachine/adapter-next
@prismicio/slice-simulator-vue
is now available through@slicemachine/adapter-nuxt2
@prismicio/slice-simulator-vue3
is now available through@slicemachine/adapter-nuxt3
Therefore, all the packages that remained where:
@prismicio/slice-simulator-com
@prismicio/slice-simulator-core
@prismicio/slice-simulator-local-controller
@prismicio/slice-simulator-com
and@prismicio/slice-simulator-core
can be merged into one. One year and a half of development has proved that such a move will streamline how these packages are used, developed, and published. Should this become an issue, we can always create an additional helper package that would take over the responsibility from the old "core" package.@prismicio/slice-simulator-local-controller
can be made a regular playground.File changed:
Checklist: