prismicio / slice-simulator

Preview and develop Prismic slices fast with minimal configuration
6 stars 5 forks source link

fix: add `fp-ts` as a dependency #9

Closed angeloashmore closed 2 years ago

angeloashmore commented 2 years ago

Types of changes

Description

This PR adds fp-ts as a dependency. @prismicio/slice-simulator-core uses io-ts as a dependency, which declares fp-ts as a peer dependency.

When using npm < 7, fp-ts is not installed automatically. The CI in this repository uses Node 16, which includes npm >= 7 and automatically installs fp-ts, thus the missing dependency does not fail tests.

Since Node 14 is currently LTS, includes npm < 7, and is the lowest version of Node we support, we must list fp-ts as a dependency for down-stream consumers of @prismicio/slice-simulator-core (such as @slicemachine/adapter-next).

See this @slicemachine/adapter-next CI run for an example where fp-ts was not installed on Node 14: https://github.com/prismicio/slicemachine-adapter-next/runs/7266557159?check_suite_focus=true

Checklist:

🐧

codecov-commenter commented 2 years ago

Codecov Report

Merging #9 (3c52af2) into master (bb99d48) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files          27       27           
  Lines         618      618           
  Branches      113      113           
=======================================
  Hits          396      396           
  Misses        222      222           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb99d48...3c52af2. Read the comment docs.

github-actions[bot] commented 2 years ago

size-limit report 📦

Path Size
./packages/com/dist/index.js 3.75 KB (0%)
./packages/com/dist/index.cjs 3.76 KB (0%)
./packages/core/dist/index.js 8.94 KB (-0.02% 🔽)
./packages/core/dist/index.cjs 17.62 KB (+0.24% 🔺)
./packages/react/dist/index.js 11.72 KB (0%)
./packages/react/dist/index.cjs 20.54 KB (+0.19% 🔺)
./packages/vue/dist/index.js 9.38 KB (0%)
./packages/vue/dist/index.cjs 18.11 KB (+0.22% 🔺)
./packages/vue3/dist/index.js 17.65 KB (0%)
./packages/vue3/dist/index.cjs 170.38 KB (+0.03% 🔺)