search

pristineio / webrtc-build-scripts

A set of build scripts useful for building WebRTC libraries for Android and iOS.
BSD 3-Clause "New" or "Revised" License
1.13k stars 447 forks source link

Enable iOS h264 support #109

Closed rayvbr closed 9 years ago

rayvbr commented 9 years ago

A few weeks ago, h264 hardware support was added. Currently, this requires setting the 'rtc_use_objc_h264' compile time flag. It would be great if this could be added to the build scripts and the pre-compiled builds.

bwilks128 commented 9 years ago

I just tried building the latest library (9554). I have been using a much older library from January but wanted to see how the latest version works. (The new library needed the VideoToolbox.framework added to link properly.)

With the latest library, I am getting just a black rectangle for my local video. Could this be related to this issue or does not having this flag simply mean it doesn't use h264 acceleration? Are you seeing a black video screen for local video as well?

Thanks.

ArikYa commented 9 years ago

Usually black local view means the local camera wasn't opened correctly. Are you using any video constraints?

bwilks128 commented 9 years ago

I don't believe so. Using the older library works fine.

bwilks128 commented 9 years ago

I take that back. You are absolutely correct. I do have some constraints in place to lower the resolution and frame rate in order to stop the video from lagging. Commenting them out does show the local view.

With some experimentation, it appears that it is setting the resolution to 320x240 that is causing the failure. Given setting the frame rate does not do anything (and the frame rate is what I really want to change), it looks like this is a problem for me until the Google folks fix the issue where setting a frame rate constraint on iOS doesn't actually change anything.

Thanks for your on target help. Sorry for adding an unrelated topic to this thread.

wlaurance commented 9 years ago

To link correctly, I had to add VideoToolbox.framework. Is this related?

ArikYa commented 9 years ago

as bwilks128 confirmed, the issue was related to the video constraints. The current version will only do 640x480

Basscord commented 9 years ago

Hi all,

If I'm reading this correctly, @bwilks128 bug was unrelated to the original feature request.

The original request:

A few weeks ago, h264 hardware support was added. Currently, this requires setting the 'rtc_use_objc_h264' compile time flag. It would be great if this could be added to the build scripts and the pre-compiled builds.

Is it possible this is still in the pipeline?

Thanks in advance!

yocontra commented 9 years ago

Did anyone figure this out?

Lenne231 commented 8 years ago

Is there any progress on this?

ibc commented 8 years ago

Same problem here. I don't find any build/common.gypi in which I can set use_objc_h264