search

pristineio / webrtc-build-scripts

A set of build scripts useful for building WebRTC libraries for Android and iOS.
BSD 3-Clause "New" or "Revised" License
1.13k stars 447 forks source link

clarify armv7s #132

Open yocontra opened 9 years ago

yocontra commented 9 years ago

https://github.com/pristineio/webrtc-build-scripts/issues/16 makes it seem as if armv7s is possible to build now, but the iOS scripts and README make no mention of it and do not build for armv7s currently. All new iOS applications must be built with armv7s otherwise they can't even upload to the app store, so this is a pretty important thing to clarify in the iOS build.

ceaglest commented 9 years ago

@contra I think you've got this incorrect. New apps must include Arm64, but do not require Armv7s. Apple would prefer if you just build for Armv7 and Arm64 at this point (the standard architectures setting in Xcode).

Several months ago I modified the pristine build scripts to support Armv7s builds, but unfortunately did not contribute this change back to the project. This is not technically a supported build config, but works by modifying the Armv7 configuration generated by Ninja. I hope this is helpful, and if there is interest in Armv7s builds I could make a PR with this change in place.

For reference, here is how OpenTok built for Armv7s: https://code.google.com/p/chromium/issues/detail?id=358921

yocontra commented 9 years ago

@ceaglest Would love to see a PR.

Also not sure how I got confused, I tried to upload an app to TestFlight and it was just like "nah, you need armv7s" so I'll double check and see what the deal is