pristineio / webrtc-build-scripts

A set of build scripts useful for building WebRTC libraries for Android and iOS.
BSD 3-Clause "New" or "Revised" License
1.13k stars 447 forks source link

Guard get_revision_number against quoted replies. #135

Closed huynguyen closed 9 years ago

huynguyen commented 9 years ago

In cases where the git log has a quoted reply from another commit the get_revision_number function gets confused returning multiple revision numbers. This causes downstream failures in the build script, particularly the linking step.

An example commit from upstream webrtc that can cause this. https://chromium.googlesource.com/external/webrtc/+/a67696b3cde98163ee38de8313ee9eddb73c662e

Error example:

Running ninja
ninja: Entering directory `out_ios_arm64_v8a/Debug-iphoneos/'
ninja: no work to do.
Running libtool
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: can't open file: 10041 (No such file or directory)
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: can't open file: 10112-ios-arm64_v8a-Debug.a (No such file or directory)
thebehera commented 9 years ago

Thanks for your contribution!