search

pristineio / webrtc-build-scripts

A set of build scripts useful for building WebRTC libraries for Android and iOS.
BSD 3-Clause "New" or "Revised" License
1.12k stars 448 forks source link

Release instead master? #144

Open oliverhausler opened 8 years ago

oliverhausler commented 8 years ago

Is there a reason why pristine builds from master? Shouldn't we build from release, instead?

https://www.chromium.org/developers/how-tos/get-the-code/working-with-release-branches https://chromium.googlesource.com/external/webrtc/+log/branch-heads/48

Due to my understanding, everything goes into master, if it properly works or not, and only a few handpicked commits make it into release. Or do I understand this wrong?

zevarito commented 8 years ago

I would like to know the answer too :)

oliverhausler commented 8 years ago

@kolencherry Can somebody of you guys comment on this please. We're confused why you're building from master.

aaalaniz commented 8 years ago

Your understanding is correct. This was just our use case when we open sourced the scripts. We pull very frequently to ensure that any conflicts caused by our changes to the source code are caught early. We have not had the bandwidth to add specific functionality to build release branches. This would not be difficult though, so feel free to submit a PR.