search

pristineio / webrtc-build-scripts

A set of build scripts useful for building WebRTC libraries for Android and iOS.
BSD 3-Clause "New" or "Revised" License
1.13k stars 447 forks source link

build_webrtc does not stop upon compile error #146

Closed ibc closed 8 years ago

ibc commented 8 years ago

I've modified a .cc file within ios/webrtc/talk/app/webrtc/ and produce a syntax error (or whatever C++ error). Then I run build_webrtc in the root directory. The compilation error is shown but the script continues and, somehow, produces a new lib.

Not sure how that is possible... Do I miss something?

ibc commented 8 years ago

To be more explicit:

../../talk/app/webrtc/videosource.cc:361:3: error: unknown type name 'FAIL'
  FAIL PLEASE
  ^
../../talk/app/webrtc/videosource.cc:361:13: error: expected ';' at end of declaration
  FAIL PLEASE
            ^
            ;
2 errors generated.
ninja: build stopped: subcommand failed.
Running libtool

________ running '/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python -c import os,sys;script = os.path.join("trunk","check_root_dir.py");_ = os.system("%s %s" % (sys.executable,script)) if os.path.exists(script) else 0' in '/Users/ibc/eFace2Face/src/webrtc-build-scripts/ios/webrtc'

So, it comes to my mind the following: If my changes to videosource.cc are valid, will build_webrtc generate a new libWebRTC.a including those changes? And how is possible that the above error does not produce a script exit?

ibc commented 8 years ago

Well, I just confirm that modifying a webrtc source file and calling build_webrtc again does not produce a new libWebRTC.a with the modifications, so basically all this stuff is useless when it comes to apply changes in libwebrtc.

ibc commented 8 years ago

My fault, I changed from RELEASE to DEBUG and pointed to the old .a, so sorry for the noise.

Anyhow, I still think that a compilation error should stop the whole build_webrtc script instead of continuing.