allow customization of GYP_DEFINES

pristineio / webrtc-build-scripts

A set of build scripts useful for building WebRTC libraries for Android and iOS.

BSD 3-Clause "New" or "Revised" License

1.13k stars 447 forks source link

allow customization of GYP_DEFINES #200

Closed RishatShamsutdinov closed 8 years ago

ArikYa commented 8 years ago

I'm not familiar with the iOS settings for GYP_DEFINES, but there might be a conflict between the default value and the customized value

RishatShamsutdinov commented 8 years ago

#!/bin/bash

WEBRTC_RELEASE=true
GYP_DEFINES="use_openssl=1 build_with_chromium=0 ios_deployment_target=8.3 clang_xcode=1"

source ./webrtc-build-scripts/ios/dance.sh

I have no conflicts here.

ArikYa commented 8 years ago

Isn't there any chance someone will want to use "chromium_ios_signing=1" ?

RishatShamsutdinov commented 8 years ago

It's problem of such people.

ArikYa commented 8 years ago

So I can't accept the pull request, just use your own forked version