pristineio / webrtc-build-scripts

A set of build scripts useful for building WebRTC libraries for Android and iOS.
BSD 3-Clause "New" or "Revised" License
1.13k stars 447 forks source link

Unify expected strings for arm architecture #213

Closed ghost closed 8 years ago

ghost commented 8 years ago

In the documentation as well as in other parts of build.sh "armv7" and "armv8" are used to decide the build architecture.

Currently there's no problem if build_apprtc() is used because it overwrites WEBRTC_ARCH. But if you only want to build one architecture and follow the readme, it says that

export WEBRTC_ARCH=armv7 or export WEBRTC_ARCH=armv8

should be used. In that case, the if inside execute_build() will fail because is looking for "armeabi-v7a" and "arm64-v8a"

ghost commented 8 years ago

The other line changes are because my text editor removes trailing whitespaces

ArikYa commented 8 years ago

Thank you @lucaslafarga fir these updates