Following along from issue #95 I updated the script to work with the release branches. I found that if I went into the iOS/webrtc/src path and checked out one of their release branches (https://groups.google.com/forum/#!topic/discuss-webrtc/UgfnLoI_Dhg) and then tried to run the build scripts, all hell broke loose. Doing some research I learned the following:
The revision number capturing grep was assuming the master branch.
I updated the gclient configuration to default to unmanaged (I did find it odd that since they say its deprecated, yet if you don't specify it defaults to the deprecated behavior?).
I added another case to the revision number grabbing code. If trying to match on refs/heads/master failed, we next try matching on refs/branch-heads. If that matches, we grab the revision number and include the branch with it. (I tested this with branch-heads/43... However now that I look at the other branches they have out there, some have decimal points and others have a p... I will revisit the get_revision_number() function in a bit to ensure it works with all the branches they have.
Lastly I added a tweak to the framework building functionality to include a Version.txt file so I know what the heck is in the .frameworks that I am tossing about in my project.
Following along from issue #95 I updated the script to work with the release branches. I found that if I went into the iOS/webrtc/src path and checked out one of their release branches (https://groups.google.com/forum/#!topic/discuss-webrtc/UgfnLoI_Dhg) and then tried to run the build scripts, all hell broke loose. Doing some research I learned the following:
I updated the gclient configuration to default to unmanaged (I did find it odd that since they say its deprecated, yet if you don't specify it defaults to the deprecated behavior?).
I added another case to the revision number grabbing code. If trying to match on
refs/heads/masterfailed, we next try matching onrefs/branch-heads. If that matches, we grab the revision number and include the branch with it. (I tested this with branch-heads/43... However now that I look at the other branches they have out there, some have decimal points and others have ap... I will revisit theget_revision_number()function in a bit to ensure it works with all the branches they have.Lastly I added a tweak to the framework building functionality to include a Version.txt file so I know what the heck is in the .frameworks that I am tossing about in my project.