search

prit29 / Coders-Calendar

An android app to manage a schedule of programming contest timing of various competitive programming platforms
https://play.google.com/store/apps/details?id=com.noobsever.codingcontests
MIT License
8 stars 7 forks source link

Make ViewPager and and attach it with TabLayout #30

Closed HemangNakarani closed 4 years ago

HemangNakarani commented 4 years ago

Reference : tablayout and view pager

ashishpatel16 commented 4 years ago

Can I take this issue?

HemangNakarani commented 4 years ago

Sure, Go Ahead !!

ashishpatel16 commented 4 years ago

@HemangNakarani Fragments are supposed to be blank for now, right?

ashishpatel16 commented 4 years ago

@HemangNakarani @prit29 I have a suggestion, In settings as well as LayoutOneActivity we have snippets of redundant code like fetching the list of tab items from SharedPreferences and saving them back to SharedPreferences using Gson.

I want to add methods for them in Utils>Methods.java class to make it look cleaner. Can I add them in the PR I'll make solving this issue #30 ?

I'll just add a public method that returns a list of strings in a fetchTabItems( ) method and one void method for saving the list using saveTabItems( ) method.

HemangNakarani commented 4 years ago

@HemangNakarani @prit29 I have a suggestion, In settings as well as LayoutOneActivity we have snippets of redundant code like fetching the list of tab items from SharedPreferences and saving them back to SharedPreferences using Gson.

I want to add methods for them in Utils>Methods.java class to make it look cleaner. Can I add them in the PR I'll make solving this issue #30 ?

I'll just add a public method that returns a list of strings in a fetchTabItems( ) method and one void method for saving the list using saveTabItems( ) method.

Yeah, Very Nice idea. Go ahead. I have opened a separate issue for it. So you can make a new PR besides this issue. @ashishpatel16 comment on #43 so I can assign it to you.

ashishpatel16 commented 4 years ago

@HemangNakarani @prit29 I've made a PR #45 . Do Suggest Changes!