search

prit29 / Coders-Calendar

An android app to manage a schedule of programming contest timing of various competitive programming platforms
https://play.google.com/store/apps/details?id=com.noobsever.codingcontests
MIT License
8 stars 7 forks source link

Add New Check Boxes in SettingsActivity #34

Closed HemangNakarani closed 4 years ago

HemangNakarani commented 4 years ago

Following CheckBoxes Should Be included in Setting activity

- Synchronize these changes with TabLayout (Tab layout Should remain Dynamic)

- Add validation: At least One CheckBox Should be selected

- Refactor Margins/Paddings : Every CardView Should Have 8dp MarginTop, Remove Padding in ScrollView

fenu28 commented 4 years ago

I want to work on this issue. Can you assign this to me?

HemangNakarani commented 4 years ago

@fenu28 Go ahed !! 👍

fenu28 commented 4 years ago

@HemangNakarani I have a confusion in the validation part of checkboxes. What I have understood and changed in the code is, if the user deselects all the checkboxes, then the Codeforces checkbox gets turned on by default and a toast message is also displayed "Atlease 1 platform has to be selected". Am I doing this in a correct way ?

HemangNakarani commented 4 years ago

@HemangNakarani I have a confusion in the validation part of checkboxes. What I have understood and changed in the code is, if the user deselects all the checkboxes, then the Codeforces checkbox gets turned on by default and a toast message is also displayed "Atlease 1 platform has to be selected". Am I doing this in a correct way ?

Yeah, you can do this, it's ok.

fenu28 commented 4 years ago

@HemangNakarani Can you guide me in this issue because my solution is not dynamic. My solution still allows user to deselect all the options and the default Codeforces is set only when onBackPressed() is called. What I am trying to implement is, as soon as user deselects all options, the Codeforces checkbox is set. I will also not be able to pull a PR bcoz there is already one PR from someone modifying the onBackPressed () method.