search

prit29 / Coders-Calendar

An android app to manage a schedule of programming contest timing of various competitive programming platforms
https://play.google.com/store/apps/details?id=com.noobsever.codingcontests
MIT License
8 stars 7 forks source link

Issue #15 solved. #47

Closed dishantvyas15 closed 4 years ago

dishantvyas15 commented 4 years ago

The PR is expected to solve issue #15 Review requested.

dishantvyas15 commented 4 years ago

@HemangNakarani Can you please have a look into this?

HemangNakarani commented 4 years ago

Great !!! @dishantvyas15 your logic is all correct, now just do one thing when user switches layout and presses the back button then user should not go in the previous layout. For it you need to finish activity while switching layouts.

One more thing just update your repo with the master branch code becayse I have just merged another PR.

HemangNakarani commented 4 years ago

@dishantvyas15 see my pr #49 You'll get the idea, it was too simple.

dishantvyas15 commented 4 years ago

I got your point. Currently, I'm stuck with some conflicts and fetch-pull things. Making a commit in a while.

dishantvyas15 commented 4 years ago

I think now it's done. Review requested.

dishantvyas15 commented 4 years ago

@HemangNakarani, I've made all the changes as directed. Before I make the commit, one question: Should I write the loadActivity() and saveActivity() functions in Methods.java ??

dishantvyas15 commented 4 years ago

I had deleted my forked repo and created a new one. As a consequence, I've made a new pull request (#51) with all the updations. Please review it.