search

pritambaral / hostapd-rtl871xdrv

Hostapd driver for RTL8188{C|CU|CUS} wifi chips.
176 stars 43 forks source link

Update .config file #3

Closed oblique closed 9 years ago

oblique commented 9 years ago

Hi,

The config that you provide it disables a lot of features and it creates a hostapd that can be use only with rtl871xdrv. I took the config options that ArchLinux use and I enabled them in the config file. With this you can use hostapd with or without rtl871xdrv. I also updated the comments of the config from the default config of hostapd.

pritambaral commented 9 years ago

disables a lot of features

No, it enables a minimal set of features. It is intended that a user of this patch enable options as they choose. This is not meant to be a distribution of hostapd, only a source of patches that enable rtl871xdrv, and as such shall contain only rtl871xdrv specific stuff. Keeps things simple

If the config or code interferes with non-rtl871xdrv drivers or features, I'll review and accept PRs that fix those.

NOTE: I'm planning on overhauling the patches into separate branches/folders/tags, each corresponding to an upstream release in a while. Your effort to add comments will be taken care of then.

Do close the PR if you don't have a counter-point.

oblique commented 9 years ago

Ok, no problem. Actually the only thing I didn't like in the config is that nl80211 driver is disabled. So, you can not use any other adapter. I checked the default config of hostapd and the only thing that is missing to enable rtl871xdrv is CONFIG_DRIVER_RTW=y.

What about suggesting the following in the README file?

cd hostapd
cp defconfig .config
echo CONFIG_DRIVER_RTW=y >> .config

With the above you can have rtl871xdrv + other drivers.

pritambaral commented 9 years ago

What about suggesting the following in the README file?

Good idea. Noted.