search

pritamzope / OS

Writing & Making Operating System and Kernel parts so simple like Hello World Programs, Starting from writing Bootloaders, Hello World Kernel, GDT, IDT, Terminal, Keyboard/Mouse, Memory Manager, HDD ATA R/W, VGA/VESA Graphics
http://createyourownos.blogspot.com
663 stars 103 forks source link

Fix terminal scrolling bug #29

Closed sasdallas closed 1 year ago

sasdallas commented 1 year ago

Hello, @pritamzope!

I opened this pull request to fix the broken method console_scroll. It should now work fine. The terminal scrolling method is applied to the NEW KERNEL Terminal folder - let me know if there are any changes!

sasdallas commented 1 year ago

@pritamzope Do you have a reason why this was closed?

pritamzope commented 1 year ago

The code you have added is not working if i press UP/DOWN keys in VESA VBE code where all screen resolutions are printed. The screen is just randomly changing text. Please add the scrolling code based on the key events and text changing. Thanks

sasdallas commented 1 year ago

I will attempt to fix it later - thanks for the response

sasdallas commented 1 year ago

The code you have added is not working if i press UP/DOWN keys in VESA VBE code where all screen resolutions are printed. The screen is just randomly changing text. Please add the scrolling code based on the key events and text changing. Thanks

Sorry for the wait, but unfortunately I don’t think I can help. I don’t believe my terminal scrolling code is suitable for anything other than text mode unfortunately. Have a great day, and thank you for this project!