Bugfix: incorrect events

priteshrnandgaonkar / react-native-call-detection

react-native package to detect call states

MIT License

191 stars 110 forks source link

Bugfix: incorrect events #78

Closed mzxyz closed 3 years ago

mzxyz commented 3 years ago

This PR try to fix the incorrect logic in callObserver delegate for iOS code.

Issue we found:

For reject / missed call action: we will get two events: diconnected and incoming which the second incoming is incorrect. For each event we should only receive one notification.

Changes:

Reorganised the logic in callObserver delegate method.
Test on iOS 14 and all looking good.

ghost commented 3 years ago

I have the same problem with incorrect events. Is there any chance that this PR will be merged asap? It would be very helpful

mzxyz commented 3 years ago

I have the same problem with incorrect events. Is there any chance that this PR will be merged asap? It would be very helpful

Have got contact with @priteshrnandgaonkar , I'm sure he will review this ASAP

marcesengel commented 3 years ago

@AnnaSviatelyk can you confirm this PR works? I don't own an iOS device to test on but I'd be willing to merge if you and @HZHAIX say it's okay with these changes.

ghost commented 3 years ago

Hi, @DragonRaider5, I've tested this PR on my iOS device, and everything works fine.

marcesengel commented 3 years ago

@priteshrnandgaonkar publishing to npm would be much appreciated. If you add me to the npm package I can do this for you as well.