[Android Bootcamp] Week 2 - Review my GridImageSearchDemo app #2

[priteshshah1983]

My app is complete, please review. /cc @codepathreview @codepath

[codepathreview]

:+1: Excellent work, Pritesh!! Few notes after checking the code:

• Good to see you used a filters object to represent the filters to apply to the query
• Correctly used Parcelable instead of Serializable
• Nice work setting up shared preferences to persist the settings between activities
• Properly used spinners (with populated values) to allow users to select filters
• Nice effort on improving the UI/UX and also implementing modal overlay for filters
• Nice job adding the share intent to the image detail view!
• Nice to see you added the search box to the ActionBar!
• Consider creating a static method in a Helper/Utility class for common methods such as checking for internet
• Consider adding progress bars to your app whenever a network request goes out in addition to the placeholder images.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[priteshshah1983]

Thanks for the feedback! I had added an Indeterminate progress bar in this commit: https://github.com/priteshshah1983/GridImageSearchDemo/commit/e9c260015abd7c9586fa0691e86963489f35afbb I had some TODOs to extract out utility methods out of the Activities, but thanks for reenforcing :)

I thought this assignment was really useful and definitely a ramp up from the Instagram Client. I don't think I could have learned so much by investing two days on learning Android with anything else.