search

privacy-protection-tools / anti-AD

致力于成为中文区命中率最高的广告过滤列表，实现精确的广告屏蔽和隐私保护。anti-AD现已支持AdGuardHome，dnsmasq， Surge，Pi-Hole，smartdns等网络组件。完全兼容常见的广告过滤工具所支持的各种广告过滤列表格式
https://anti-ad.net
MIT License
8.3k stars 723 forks source link

[误杀]Your domains list causes photos broken which are inserted on GitHub when enabling DNS filtering in AG for Android. #81

Closed lancelot-moon closed 4 years ago

lancelot-moon commented 4 years ago

Your domains list causes photos broken which are inserted on GitHub when enabling DNS filtering in AG for Android. I tested on Android. Clear cache before the test. ex: Photos were broken on GitHub:

Screenshot: ![image](https://i.imgur.com/8qyDC0o.jpg)

No problem on PC. (I also subscribed to your domains list in my router for DNS filtering.) I tried your other formats list, ex: basic rule syntax, which is no problem. https://raw.githubusercontent.com/privacy-protection-tools/anti-AD/master/anti-ad-easylist.txt The problem is only with your **domains list**. https://raw.githubusercontent.com/privacy-protection-tools/anti-AD/master/anti-ad-domains.txt Maybe something wrong between your domains list and AG for Android.
welcome[bot] commented 4 years ago

Thank you for opening your first issue in this repo. It’s people like you who make anti-AD better!

lancelot-moon commented 4 years ago

After checking, AG for iOS v4 beta with anti-AD domains list also has the problem of broken photos on GitHub. With anti-AD basic rule syntax list, no problem.

gentlyxu commented 4 years ago

can you please provide some log about this problem?

ghost commented 4 years ago

collector.githubapp.com 测试了一下，似乎是这个域名，但中国屏蔽了部分raw.githubusercontent.com的ip，无法完全确定

can you please provide some log about this problem?

lancelot-moon commented 4 years ago

The now logic for only domains list in AG for PC/Browser Extension/Android/iOS causes the incorrect blocking on HTTPS or DNS level. githubusercontent.com is wrongly blocked by the domain rule, ntent.com, even if they're different domains.

Screenshots: ![image](https://i.imgur.com/nJcUxSn.jpg) ![image](https://i.imgur.com/s2YNdHe.jpg)

AG Home with domains list doesn't have the issue because its logic is different and correct. I think AG team will redesign it. https://github.com/AdguardTeam/DnsLibs/issues/66#issuecomment-605156082 It's not your domains list's problem. You can close this.
gentlyxu commented 4 years ago

collector.githubapp.com

测试了一下，似乎是这个域名，但中国屏蔽了部分raw.githubusercontent.com的ip，无法完全确定

can you please provide some log about this problem?

@Leisuredpootle 谢谢你的帮忙，现在问题清晰了，我也查了你提供的域名并不在屏蔽列表。

这个bug需要adguard官方去修复了