search

privacy-scaling-explorations / chiquito

DSL for Halo2 circuits
https://docs.pecadorplonkish.xyz/
161 stars 36 forks source link

242 make debugsymref usable #243

Closed alxkzmn closed 1 month ago

leolara commented 1 month ago

You have done more than the, task, I was going to put calculating the line and col in anther task!!

Do you think it is a good optimization to put the file name in Rc or Rc ?

alxkzmn commented 1 month ago

@leolara thanks! :) I found that crate because I was curious how others are logging errors, so that we don't reinvent the wheel. What is "Rc"?

leolara commented 1 month ago

@alxkzmn I mean this https://doc.rust-lang.org/std/rc/struct.Rc.html so we don't copy the filename string.

alxkzmn commented 1 month ago

Sure, that's a better way!

leolara commented 1 month ago

@alxkzmn aparently Rc is more efficient https://www.reddit.com/r/rust/comments/qlbl3v/rcstr_vs_rcstring_for_interpreter/

leolara commented 1 month ago

@alxkzmn can you merge?