search

privacy-scaling-explorations / chiquito

DSL for Halo2 circuits
https://docs.pecadorplonkish.xyz/
161 stars 36 forks source link

WG interpreter #252

Closed leolara closed 3 weeks ago

leolara commented 1 month ago

Please,. check again @alxkzmn

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.87786% with 148 lines in your changes missing coverage. Please review.

Please upload report for BASE (chiquito-2024@97f334b). Learn more about missing BASE report.

:exclamation: Current head 1d1357f differs from pull request most recent head 9e09a05

Please upload reports for the commit 9e09a05 to get more accurate results.

Files Patch % Lines
src/interpreter/expr.rs 38.33% 37 Missing :warning:
src/interpreter/mod.rs 91.60% 32 Missing :warning:
src/interpreter/value.rs 48.88% 23 Missing :warning:
src/plonkish/ir/assignments.rs 0.00% 11 Missing :warning:
src/parser/ast/expression.rs 0.00% 10 Missing :warning:
src/poly/mod.rs 93.75% 8 Missing :warning:
src/plonkish/backend/halo2.rs 30.00% 7 Missing :warning:
src/interpreter/frame.rs 94.64% 6 Missing :warning:
src/sbpir/mod.rs 62.50% 6 Missing :warning:
src/compiler/compiler.rs 95.71% 3 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## chiquito-2024 #252 +/- ## ================================================ Coverage ? 62.68% ================================================ Files ? 45 Lines ? 12326 Branches ? 0 ================================================ Hits ? 7727 Misses ? 4599 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alxkzmn commented 1 month ago

Thanks for all the comments! All looks good to me.

leolara commented 4 weeks ago

@alxkzmn after the TraceGenerator refactoring I am going to refactor this to use that