Schnorr signature based on traditional DLP and ECDLP are not distinguished.
Location
Module Name: Module 3
Section/Step: Schnorr Signatures
Proposed Correction
Schnorr signature was originally published based on traditional Discrete Logarithm Problem. EC(Elliptic Curve)-Schnorr was introduced later.
These two seems not to be distinguished strictly in several materials. Among 5 links of Schnorr signature in Module 3, two links describe DLP version while other links describe EC version.
Erasing DLP links would be one solution.
However I suggest the way to move DLP-Schnorr signature to Module 2, as we introduced only one digital signature scheme(DSA) in Module 2. (Historically, DSA is proposed with intent to avoid patent issue of original Schnorr signature.)
Please let me know if you have other opinion, and thanks for your hard work writing these helpful materials! 😄
@jae-cuz Thank you for this issue! This is a great point and I think your recommendation makes a lot of sense. Looking forward to seeing a PR with your suggested changes.
Summary
Schnorr signature based on traditional DLP and ECDLP are not distinguished.
Location
Proposed Correction
Schnorr signature was originally published based on traditional Discrete Logarithm Problem. EC(Elliptic Curve)-Schnorr was introduced later. These two seems not to be distinguished strictly in several materials. Among 5 links of Schnorr signature in Module 3, two links describe DLP version while other links describe EC version.
Erasing DLP links would be one solution. However I suggest the way to move DLP-Schnorr signature to Module 2, as we introduced only one digital signature scheme(DSA) in Module 2. (Historically, DSA is proposed with intent to avoid patent issue of original Schnorr signature.)
Please let me know if you have other opinion, and thanks for your hard work writing these helpful materials! 😄
Screenshots (if applicable)
Additional Context
schnorr vs ec-schnorr