search

privacy-scaling-explorations / halo2

https://privacy-scaling-explorations.github.io/halo2/
Other
208 stars 129 forks source link

In key generation, figure out if we need l_0(X) computed more efficiently #269

Closed ed255 closed 3 weeks ago

ed255 commented 9 months ago

In the key generation we find the following TODO: https://github.com/privacy-scaling-explorations/halo2/blob/73408a140737d8336490452193b21f5a7a94e7de/halo2_proofs/src/plonk/keygen.rs#L360-L365

We need to figure out:

  1. Is it worth doing this part more efficiently? In my opinion, if this part represents a <1% of the key gen time, there's no need to improve it.
  2. If we want to do it more efficiently, figure out how, and do it.
adria0 commented 1 month ago

@davidnevadoc is https://github.com/privacy-scaling-explorations/halo2/pull/363 closing this issue?