privacy-scaling-explorations / halo2

https://privacy-scaling-explorations.github.io/halo2/
Other
201 stars 121 forks source link

fix: expose more types for external projects #314

Closed duguorong009 closed 5 months ago

duguorong009 commented 5 months ago

Description

Check & expose more types in halo2_proofs crate for compatibility of external projects. The list of external projects used for checking is this one - https://hackmd.io/HR_tdY-_QzCOe6fZUJBDeA.

Related issues

Changes

This PR exposes:

NOTE

In addition to newly-exposed types, there is one more - halo2_proofs::arithmetic::FieldExt. Originally, this one is the re-export of pasta_curves::FieldExt in halo2curves crate. This re-export was removed in this commit. https://github.com/privacy-scaling-explorations/halo2curves/commit/ce743c09e516cbc1cc8cb6da3cf6d420e914bc6a#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759L15 OR, halo2_proofs-v0.2.0 used the direct re-export of FieldExt, by using pasta_curves::arithmetic::*.(https://github.com/privacy-scaling-explorations/halo2/blob/halo2_proofs-0.2.0/halo2_proofs/src/arithmetic.rs#L11)