We disable two checks on key generation that made sure the row being filled was within the usable rows.
These checks are not necessary for fixed columns (where we disabled them), because fixed columns are public and are not blinded. Indeed, they are computed at setup time.
These checks served as a sanity check though, because in general one would not want to assign values at unusable offsets. On exception is the case of lookups. Thanks to this change, we can now run circuits with 2^k lookup tables on a k-domain. Before this change, a (k+1)-domain was needed.
This solution is good IMHO, but I suggest opening a GitHub issue to revisit this problem in the future to possibly enable/disable the check via an additional argument to the assign_fixed function.
CLOSING THIS AT IT REQUIRES MORE CHANGES.
We disable two checks on key generation that made sure the row being filled was within the usable rows.
These checks are not necessary for fixed columns (where we disabled them), because fixed columns are public and are not blinded. Indeed, they are computed at setup time.
These checks served as a sanity check though, because in general one would not want to assign values at unusable offsets. On exception is the case of lookups. Thanks to this change, we can now run circuits with
2^klookup tables on ak-domain. Before this change, a(k+1)-domain was needed.This solution is good IMHO, but I suggest opening a GitHub issue to revisit this problem in the future to possibly enable/disable the check via an additional argument to the
assign_fixedfunction.