fix!: correct the `compile_circuit`

[guorong009]

Description

Correct the logic of converting selectors to fixed columns in compile_circuit

Related issues

• None

Changes

• update compile_circuit add the logic of considering the selectors_poly when computing fixed columns
• add a new ci check for running the examples
  • create a new sh script to test the successful run of examples
  • add ci check in github actions

Context

If you try to run the shuffle example in current main branch, you can find that it is failing here.

cargo run --package halo2_proofs --example shuffle 

The reason is that there is tiny error in the implementation converting selectors to fixed column, in compile_circuit. This PR resolves this issue.

[ed255]

If you try to run the shuffle example in current main branch, you can find that it is failing here.

cargo run --package halo2_proofs --example shuffle 

I think this is showing a big problem we have, we don't have enough unit tests, and the real tests that we have are examples but they are not run via github actions. I think we should run the examples as check via github actions for every PR.

[guorong009]

If you try to run the shuffle example in current main branch, you can find that it is failing here.

cargo run --package halo2_proofs --example shuffle 

I think this is showing a big problem we have, we don't have enough unit tests, and the real tests that we have are examples but they are not run via github actions. I think we should run the examples as check via github actions for every PR.

Yes, I agree. @ed255 Here, I add the CI to check examples running. 5627fce https://github.com/privacy-scaling-explorations/halo2/pull/320/commits/41e4da277206eb69502944f61fca465d7e0b3829

[guorong009]

Close this PR in favor of #322 .