privacy-scaling-explorations / halo2

https://privacy-scaling-explorations.github.io/halo2/
Other
207 stars 129 forks source link

fix!: correct the `compile_circuit` #320

Closed guorong009 closed 5 months ago

guorong009 commented 6 months ago

Description

Correct the logic of converting selectors to fixed columns in compile_circuit

Related issues

Changes

Context

If you try to run the shuffle example in current main branch, you can find that it is failing here.

cargo run --package halo2_proofs --example shuffle 

The reason is that there is tiny error in the implementation converting selectors to fixed column, in compile_circuit. This PR resolves this issue.

ed255 commented 6 months ago

If you try to run the shuffle example in current main branch, you can find that it is failing here.

cargo run --package halo2_proofs --example shuffle 

I think this is showing a big problem we have, we don't have enough unit tests, and the real tests that we have are examples but they are not run via github actions. I think we should run the examples as check via github actions for every PR.

guorong009 commented 6 months ago

If you try to run the shuffle example in current main branch, you can find that it is failing here.

cargo run --package halo2_proofs --example shuffle 

I think this is showing a big problem we have, we don't have enough unit tests, and the real tests that we have are examples but they are not run via github actions. I think we should run the examples as check via github actions for every PR.

Yes, I agree. @ed255 Here, I add the CI to check examples running. 5627fce https://github.com/privacy-scaling-explorations/halo2/pull/320/commits/41e4da277206eb69502944f61fca465d7e0b3829

guorong009 commented 5 months ago

Close this PR in favor of #322 .