search

privacy-scaling-explorations / halo2

https://privacy-scaling-explorations.github.io/halo2/
Other
201 stars 121 forks source link

Update halo2curves dependency #326

Closed ed255 closed 3 months ago

ed255 commented 4 months ago

Update it to 0.6.1

guorong009 commented 3 months ago

Do we really need this update? According to this rust doc, the dependency version is automatically resolved by resolver.

Anyhow, I've created the PR for best.

ed255 commented 3 months ago

Do we really need this update? According to this rust doc, the dependency version is automatically resolved by resolver.

Anyhow, I've created the PR for best.

Oh you're right! Previously we had 

halo2curves = { version = "0.6.1", default-features = false }

And the resolver would translate it to this constraint:

>=0.6.1, <1.0.0

Which includes 0.6.2. I didn't know about this before. So I think we can avoid having this small unnecessary updates in the future :)