search

privacy-scaling-explorations / halo2

https://privacy-scaling-explorations.github.io/halo2/
Other
208 stars 129 forks source link

feat: add halo2_debug package #346

Closed ed255 closed 5 months ago

ed255 commented 5 months ago

Introduce a halo2_debug package that fills the need identified in https://github.com/privacy-scaling-explorations/halo2/issues/343

For now it only contains helper types to nicely display prime fields, expressions, lookups and shuffles.

As an example usage I extended the compress_selectors tests: https://github.com/privacy-scaling-explorations/halo2/blob/458ad7090eaf28f91e2218297c0f026dc7a12cd8/halo2_proofs/tests/compress_selectors.rs#L465-L476.

NOTE: I just saw this https://github.com/privacy-scaling-explorations/halo2/pull/345 we'll have to converge into the same name :smile:

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 90.56604% with 25 lines in your changes missing coverage. Please review.

Project coverage is 82.28%. Comparing base (80e69b9) to head (5750849). Report is 1 commits behind head on main.

Files Patch % Lines
halo2_middleware/src/circuit.rs 56.25% 14 Missing :warning:
halo2_debug/src/display.rs 97.27% 6 Missing :warning:
halo2_backend/src/plonk/circuit.rs 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #346 +/- ## ========================================== + Coverage 81.90% 82.28% +0.38% ========================================== Files 82 83 +1 Lines 17019 17458 +439 ========================================== + Hits 13939 14366 +427 - Misses 3080 3092 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adria0 commented 5 months ago

NOTE: I just saw this #345 we'll have to converge into the same name 😄

Renamed to halo2_debug https://github.com/privacy-scaling-explorations/halo2/pull/345/commits/0c5481951828698e3e5bc0ba65cd40dde0bab68e