patch: include more fields to transcript

guorong009 commented 3 months ago

Description

Add more conditionally-debugged fields to transcript_repr

Related issues

Resolve #350

Changes

add multi-phase related challenge fields to PinnedConstraintSystem::fmt
update the plonk_api test

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.86%. Comparing base (d52ebca) to head (2cd5d8f).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #351 +/- ## ========================================== - Coverage 81.89% 81.86% -0.03% ========================================== Files 82 82 Lines 17008 16984 -24 ========================================== - Hits 13928 13904 -24 Misses 3080 3080 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

guorong009 commented 3 months ago

@ed255 @han0110 Before I merge the PR, can you check if any more fields should be added to transcript_repr? If you think no more, then I will merge the PR.

han0110 commented 3 months ago

I think this is all, but I just realized we could just bring back the #[derive(Debug)] like in upstream, so we are sure we will not miss any fields.

privacy-scaling-explorations / halo2