Make Expression copiable using singleton arena

privacy-scaling-explorations / halo2

Other

201 stars 121 forks source link

NOTE: Relevant files to review are halo2_frontend/src/plonk/circuit/{expession.rs, arena.rs}

This an experiment about making expression copiable. To implement this we go with this strategy:

Create a type called ExprRef<F> that contains the index (usize) of an expression stored in an specific arena.
Modify the struct Expression to use ExprRef instead the a recursive Expression that makes it non-copiable.
In order to access to the Expression arenas, we create a new trait that allows to access to the expression arena for an specific field, called FieldFront. Mainly we change all frontend from Field to FieldFront, making arena accessible everywhere.

pub trait FieldFront: Field {
    // Since base trait is not referenciable, we need a way to access it.
    // This is necessary to provide a way to transform fields from/to backend.
    type Field: Field;
    fn into_field(self) -> Self::Field;
    fn into_fieldfront(f: Self::Field) -> Self;

    // Allocate a new expression
    fn alloc(expr: Expression<Self>) -> ExprRef<Self>;

    // Get an expression
    fn get(ref_: &ExprRef<Self>) -> Expression<Self>;

    // Replace an expression
    fn replace(expr: Expression<Self>, ref_: &ExprRef<Self>);
}

This means:

Library users needs to change <Field> for <FieldFront> and automatically all their Expressions are automatically copiable. This is thread-safe.
Arenas are not dropped and lives until the whole program is finished.
Arenas are field-especific and cannot be defined outside the halo2_crate ( this is due that is not possible to implement external traits on external types ).

Files	Patch %	Lines
halo2_frontend/src/plonk/circuit/expression.rs	69.11%	63 Missing :warning:
halo2_frontend/src/dev/failure.rs	12.50%	7 Missing :warning:
halo2_frontend/src/plonk/circuit.rs	0.00%	4 Missing :warning:
halo2_proofs/src/plonk/prover.rs	98.05%	4 Missing :warning:
halo2_frontend/src/dev/tfp.rs	0.00%	3 Missing :warning:
halo2_proofs/src/plonk.rs	50.00%	2 Missing :warning:
halo2_frontend/src/dev/failure/emitter.rs	0.00%	1 Missing :warning:
halo2_frontend/src/dev/gates.rs	0.00%	1 Missing :warning:
...o2_frontend/src/plonk/circuit/constraint_system.rs	66.66%	1 Missing :warning:

Files

Patch %

Lines

halo2_frontend/src/plonk/circuit/expression.rs

69.11%

63 Missing :warning:

halo2_frontend/src/dev/failure.rs

12.50%

7 Missing :warning:

halo2_frontend/src/plonk/circuit.rs

0.00%

4 Missing :warning: