Closed ed255 closed 1 month ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 59.52381%
with 51 lines
in your changes missing coverage. Please review.
Project coverage is 82.48%. Comparing base (
bc857a7
) to head (da4983e
).
Files | Patch % | Lines |
---|---|---|
halo2_debug/src/check_witness.rs | 58.19% | 51 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Complete the implementation of the
check_witness
function which checks that a witness assignment passes all the constraints from a middleware Circuit. The missing parts were:I've tried to keep the implementation simple (compared to the MockProver). For now it panics instead of returning errors.
This function was previously defined in the
p3_frontend
but is now moved tohalo2_debug
so that it can be used anywhere.