search

privacy-scaling-explorations / halo2

https://privacy-scaling-explorations.github.io/halo2/
Other
207 stars 129 forks source link

fix: make lookup-any-sanity-checks optional in halo2_proofs #358

Closed ed255 closed 4 months ago

ed255 commented 4 months ago

halo2_proofs was importing halo2_frontend with the default features, so there was no way to disable lookup-any-sanity-checks when using halo2_proofs.

Now halo2_proofs imports halo2_frontend without default features, and the dependencies features are completely controlled by the user via the halo2_proofs features. I did the same for halo2_backend to achieve the same level of control.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.64%. Comparing base (445d1da) to head (eaaefe1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #358 +/- ## ======================================= Coverage 82.64% 82.64% ======================================= Files 84 84 Lines 17750 17750 ======================================= Hits 14670 14670 Misses 3080 3080 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.