Closed guorong009 closed 1 month ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 68.85246%
with 19 lines
in your changes missing coverage. Please review.
Project coverage is 85.01%. Comparing base (
7c368af
) to head (6061bf6
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think that is really nice, anything that de-obfuscates halo2 is welcomed! thanks for taking care about it! I request changes. I think that there's a missing
CHANGES.TXT
(or whatever) describing the breaking changes.
Currently, the halo2_proofs
crate includes the CHANGELOG.md
which seems not used at all.
I think the changes are just summarized in release PR.
Maybe, do we need explicit CHANGELOG file for documentation?
cc @davidnevadoc
I think that is really nice, anything that de-obfuscates halo2 is welcomed! thanks for taking care about it! I request changes. I think that there's a missing
CHANGES.TXT
(or whatever) describing the breaking changes.Currently, the
halo2_proofs
crate includes theCHANGELOG.md
which seems not used at all. I think the changes are just summarized in release PR. Maybe, do we need explicit CHANGELOG file for documentation? cc @davidnevadoc
Mmmmmm... yes, I see. Updating the halo2_proofs/CHANGELOG.md
should be enough. Let's do it when doing a release!
I also think that we have to move CHANGELOG.md
to repo root, wdyt @guorong009 ?
Description
Improve the verify api -
verify_proof
, in a way that it does return thebool
value indicating proof is valid or not. This way, we remove the confusion or misuse, related toverify_proof
api.Related issues
Changes
VerificationStrategy
implsverify_proof
so that it returns thebool