search

privacy-scaling-explorations / halo2

https://privacy-scaling-explorations.github.io/halo2/
Other
208 stars 129 forks source link

fix(evaluation): fix the wrong eval_data of input_evaluator in shuffle #370

Closed nanne007 closed 1 month ago

nanne007 commented 2 months ago

If input expression of a shuffle contains more rotations than shuffle expression, the code will abort.

I believe this is a typo.

nanne007 commented 2 months ago

cc @kilic

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.99%. Comparing base (486770c) to head (619d1e1). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #370 +/- ## ======================================= Coverage 84.99% 84.99% ======================================= Files 85 85 Lines 18684 18684 ======================================= Hits 15880 15880 Misses 2804 2804 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.