Refactor `BN` curves. - Githubissues

privacy-scaling-explorations / halo2curves

Other

171 stars 136 forks source link

Refactor `BN` curves. #105

Open davidnevadoc opened 10 months ago

davidnevadoc commented 10 months ago

The BN curves Pluto and bn256 can a good amount of code that is currently duplicated (once #98 is merged). In order to fix this we should introduce macros for:

Field extensions.
BN pairing.

This will be a good opportunity to refactor some of bn256 code which is in many parts undocumente and at times quite unclear.

mratsim commented 9 months ago

Ideally I would also do renaming/breaking changes:

rename to bn254
Engine is a very bad name for the pairing trait and it should be called Pairing: https://github.com/privacy-scaling-explorations/halo2curves/blob/2e7f8eb8ba1cf8e09c6c05f9f1c2f79d02002fc9/src/bn256/engine.rs#L635-L646