search

privacy-scaling-explorations / halo2curves

Other
172 stars 137 forks source link

Clean up codes and docs in pairing of BN256 & Pluto #147

Open John-Gong-Math opened 6 months ago

John-Gong-Math commented 6 months ago

This PR is aimed to clean up the pairing implementations bn256/engine.rs and pluto_eris/engine.rs.

  1. Correct and detail the docs by adding more references and intuitions, especially about the type G2Prepared and the case U<0 of the curve Pluto.
  2. Clean up the code used in pluto_eris/engine.rs to make it in line with the BN256 case.
kilic commented 6 months ago

@John-Gong-Math Can we go a little further and merge two loops over NEG_SIX_U_PLUS_2_NAF and as a result get rid of G2Prepared?

John-Gong-Math commented 6 months ago

@John-Gong-Math Can we go a little further and merge two loops over NEG_SIX_U_PLUS_2_NAF and as a result get rid of G2Prepared?

Thank for both of you for the comments. I will update the codes in the next commits.