privacy-scaling-explorations / maci-platform

MACI Platform - Voting and Funding using MACI
https://maci-platform.vercel.app
10 stars 12 forks source link

Remove appending tally json filename from Tally URL #143

Open BenBarahona opened 3 months ago

BenBarahona commented 3 months ago

Currently, when defining the NEXT_PUBLIC_TALLY_URL, the application will append "/tally-0.json" to the GET request and use the URL set on the described env var. I found this unintuitive and restricts the name of the tally file. Would it be possible to define the whole tally URL on the env var and not have the frontend append the filename at the end?

ctrlc03 commented 3 months ago

would it help if we removed "Tally-" (and thus the name from from the .env var) and just kept the poll Id as variable parameter? in the future we could add support on the frontend for running multiple rounds where the poll ID might be different so keeping it as a variable would help with that

BenBarahona commented 3 months ago

That works, yeah! Maybe on the docs also add so that the actual filename must be tally-{id} so it's clear that the tally file must have the specific filename.

ctrlc03 commented 3 months ago

That works, yeah! Maybe on the docs also add so that the actual filename must be tally-{id} so it's clear that the tally file must have the specific filename.

totally, thanks for the feedback :)