Improvements and Bugs on Review Applications page

[crisgarner]

• [x] After a project has been approved it takes a while for the status to be updated (even though on the other page, it appears accepted.
• [ ] There is no way to reject projects.
• [x] Filter / Search projects for the coordinators.
• [x] Once an application is approved it takes a lot to be displayed as approved, leaving to some UI bugs.

Screenshots are visible on: https://www.notion.so/pse-team/RPGF-feedback-1476b27526574f8aa8ae677988b7f135

[aguzmant103]

Could have been solved in Easy-RetroPGF like in commit Careful with ehterjs version https://github.com/gitcoinco/easy-retro-pgf/commit/2a5cd405eb3b99e0724c8b6ede089830ad6df01a

[aguzmant103]

• [ ] There is no way to reject projects once they have been approved

[ctrlc03]

@aguzmant103 @crisgarner we could probably have a button to revoke the attestation once approved, but actually rejecting an application might be difficult (for that we probably would need to create another schema "rejected applications" and map an application to this new eas schema and do the filtering while pulling the data)

[crisgarner]

We could update the query to not show it once revoked, the main issue is that the applications always stay on the admin page. We can use the same schema as the one we use is revokable

https://github.com/privacy-scaling-explorations/maci-rpgf/blob/86228a02fcc5b230a0bf3fb60abe3ac7d8016725/src/utils/fetchAttestations.ts#L50

[ctrlc03]

We could update the query to not show it once revoked, the main issue is that the applications always stay on the admin page. We can use the same schema as the one we use is revokable

https://github.com/privacy-scaling-explorations/maci-rpgf/blob/86228a02fcc5b230a0bf3fb60abe3ac7d8016725/src/utils/fetchAttestations.ts#L50

can we revoke the one created by the user when applying as a way of rejecting?

[crisgarner]

Now that you mention it, not sure if we can revoke their attestation as they created it. Currently, the flow is:

1. User creates an application for the round, for example
2. The coordinator/admin creates an attestation and references the previous one. example

We kind of assume that any attestation done is an approval, a quick fix would be to create another approval schema and add the status field to save if approved or rejected.

[ctrlc03]

Now that you mention it, not sure if we can revoke their attestation as they created it. Currently, the flow is:

1. User creates an application for the round, for example
2. The coordinator/admin creates an attestation and references the previous one. example

We kind of assume that any attestation done is an approval, a quick fix would be to create another approval schema and add the status field to save if approved or rejected.

Ok right so we basically create one same way as if we are approving it but set it to rejected, and then can filter later based on that field. that works

[crisgarner]

Now that you mention it, not sure if we can revoke their attestation as they created it. Currently, the flow is:

1. User creates an application for the round, for example
2. The coordinator/admin creates an attestation and references the previous one. example

We kind of assume that any attestation done is an approval, a quick fix would be to create another approval schema and add the status field to save if approved or rejected.

Ok right so we basically create one same way as if we are approving it but set it to rejected, and then can filter later based on that field. that works

yeah exactly, we wouldn't need to revoke anymore, just create an attestation and set the status to false, and when approving set it to true.

[ctrlc03]

Now that you mention it, not sure if we can revoke their attestation as they created it. Currently, the flow is:

1. User creates an application for the round, for example
2. The coordinator/admin creates an attestation and references the previous one. example

We kind of assume that any attestation done is an approval, a quick fix would be to create another approval schema and add the status field to save if approved or rejected.

Ok right so we basically create one same way as if we are approving it but set it to rejected, and then can filter later based on that field. that works

yeah exactly, we wouldn't need to revoke anymore, just create an attestation and set the status to false, and when approving set it to true.

will open as a separate issue

[kittybest]

split the first and fourth issues to #213

[kittybest]

the second issues is re-opened here: #193 the first and fourth issues are re-opened here: #213, and already implemented. the third issue is closed by #82, if there's any more specific description for this problem, please just open another new issue.