feat: make sure contract deployment does work in the frontend

privacy-scaling-explorations / maci-rpgf

EasyRetroPGF with MACI

https://maci-rpgf.vercel.app

MIT License

6 stars 4 forks source link

feat: make sure contract deployment does work in the frontend #86

Closed kittybest closed 2 months ago

kittybest commented 2 months ago

Deploy contracts through a "deploy" button.

[x] create a hook for coordinator page deployment
[x] connect the deploy contract button to the deploy function
[x] remove existing topup related code
[x] add Poseidon Contract addresses as constants, since there are problems deploying them
[x] remove deployPoseidon functions
[x] add tree_depth as constants, since user won't need to change it through the frontend so far
[x] add deployPoll function
[x] read poll and maci data from localStorage instead of env variable
[x] change reading maci from env to input in server/api/router/ballot
[x] update tests
[ ] add wizard for each contract deployment --> thinking about open another PR for this?

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
maci-rpgf	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 22, 2024 0:46am

kittybest commented 2 months ago

--> this error is also because Deployment require the user to input eth_maxPriorityFeePerGas, but this error doesn't affect contract deployment.

kittybest commented 2 months ago

【5/11 update】 Deployment only failed on deploying MACI.

--> so this is because of "poseidon libraries not linked"

--> this is because of linked poseidon contracts acting weird, could be normally deployed if other existing poseidon addresses provided. Need to check what happened to the poseidon contract deployment.

kittybest commented 2 months ago

This what happened sometimes while calling deployContractWithLinkedLibraries, could happen during deployPollFactory or deployMessageProcessorFactory or deployTallyFactory or deployMaci, but would work after recall the same function.

kittybest commented 2 months ago

UPDATE: solved

problem here: there's a problem here after rewriting the ballot router.

ctrlc03 commented 2 months ago

problem here: there's a problem here after rewriting the ballot router.

is this related to the changes of this PR?

kittybest commented 2 months ago

problem here: there's a problem here after rewriting the ballot router.

is this related to the changes of this PR?

I think yes? Since it works before, still try to figure out the problem😥

0xmad commented 2 months ago

All tests for maci service are failed and there are no tests for new functionality

kittybest commented 2 months ago

All tests for maci service are failed and there are no tests for new functionality

failed now because I remove the vkey file, update error-handler later. would add tests for new functions later.

0xmad commented 2 months ago

All tests for maci service are failed and there are no tests for new functionality

failed now because I remove the vkey file, update error-handler later. would add tests for new functions later.

They are failed not only because of it. It's also because tests are not updated after adding the new logic.

kittybest commented 2 months ago

update tests, if there's something that should be test but not yet be tested, please just leave a comment.

BTW, this PR won't be merged to the main, should be merged to a new branch: feat/deployment-service, which should contain all the deployment service content: https://github.com/privacy-scaling-explorations/maci-rpgf/tree/feat/deployment-service