privacy-scaling-explorations / maze

Multi proof Aggregation for Zk SNARK on Ethereum
61 stars 2 forks source link

install error due to foundry-evm dependency #4

Closed socathie closed 1 year ago

socathie commented 1 year ago

The new commit seems to resolve #3 but a new error arises, which seems to be related to this issue of foundry-rs. Looked through the solution but nothing really helps. Error log:

   Compiling foundry-evm v0.2.0 (https://github.com/foundry-rs/foundry?rev=e53c0d2338e447bb2468d2c2b183fd21df6b3494#e53c0d23)
error[E0283]: type annotations needed
  --> /Users/sty/.cargo/git/checkouts/foundry-f7cca724e93059b0/e53c0d2/evm/src/fuzz/strategies/int.rs:33:46
   |
33 |         let new_mid = self.lo + interval / 2.into();
   |                                          -   ^^^^
   |                                          |
   |                                          type must be known at this point
   |
   = note: cannot satisfy `_: Into<ethers::types::I256>`
   = note: required for `ethers::types::I256` to implement `std::ops::Div<_>`
help: try using a fully qualified path to specify the expected types
   |
33 |         let new_mid = self.lo + interval / <i32 as Into<T>>::into(2);
   |                                            +++++++++++++++++++++++ ~

error[E0283]: type annotations needed
  --> /Users/sty/.cargo/git/checkouts/foundry-f7cca724e93059b0/e53c0d2/evm/src/fuzz/strategies/int.rs:72:60
   |
72 |         self.lo = self.curr + if self.hi < 0.into() { (-1).into() } else { 1.into() };
   |                             -                              ^^^^
   |                             |
   |                             type must be known at this point
   |
   = note: cannot satisfy `_: Into<ethers::types::I256>`
   = note: required for `ethers::types::I256` to implement `std::ops::Add<_>`
help: try using a fully qualified path to specify the expected types
   |
72 |         self.lo = self.curr + if self.hi < 0.into() { <i32 as Into<T>>::into((-1)) } else { 1.into() };
   |                                                       +++++++++++++++++++++++    ~

error[E0283]: type annotations needed
   --> /Users/sty/.cargo/git/checkouts/foundry-f7cca724e93059b0/e53c0d2/evm/src/fuzz/strategies/int.rs:122:30
    |
122 |             1 => -offset - 1.into(),
    |                          -   ^^^^
    |                          |
    |                          type must be known at this point
    |
    = note: cannot satisfy `_: Into<ethers::types::I256>`
    = note: required for `ethers::types::I256` to implement `std::ops::Sub<_>`
help: try using a fully qualified path to specify the expected types
    |
122 |             1 => -offset - <i32 as Into<T>>::into(1),
    |                            +++++++++++++++++++++++ ~
jeong0982 commented 1 year ago

I think this issue will be fixed after this PR is merged. It was proposed 4 days ago, so we should wait for. If that PR is not merged for a long time, I will fork foundry-rs and resolve that issue.

jeong0982 commented 1 year ago

PR in foundry-rs is merged, does this error still arise?

socathie commented 1 year ago

seems like I'm still getting the same error, even after I clear cargo cache of git repositories

jeong0982 commented 1 year ago

I made update for dependency, can you check it with new commit?

socathie commented 1 year ago

Can confirm install works fine now. Thank you so much!