privacy-scaling-explorations / pse.dev

The PSE website
https://pse.dev
17 stars 32 forks source link

btw (out of scope of this PR), have you considered using an enum for this? #187

Open kalidiagne opened 1 month ago

kalidiagne commented 1 month ago
          btw (out of scope of this PR), have you considered using an enum for this?
  projectStatus: ProjectStatus.Inactive,

which would be defined in @/lib/types

As a dev not familiar with this repo, I had to look for a project which I knew was inactive and check for its data to know what exact string to use. No big deal, but an enum would force doing the right thing automatically.

_Originally posted by @sripwoud in https://github.com/privacy-scaling-explorations/pse.dev/pull/186#discussion_r1721718778_

samajammin commented 2 weeks ago

Makes sense to me 👍