search

privacy-scaling-explorations / snark-artifacts

A streamlined mechanism for distributing SNARK artifacts.
https://snark-artifacts.pse.dev
MIT License
4 stars 2 forks source link

feat(web): download all artifacts as tarball #108

Closed sripwoud closed 5 months ago

sripwoud commented 5 months ago

Closes #107 Closes #110 image

Test plan

  1. pnpm --filter web dev
  2. Select project then version
  3. Download is disabled
  4. Tick all:
    • select input should be disabled
    • checkbox has a tooltip
    • Download button is enabled
  5. Click dowload: you get the expected tarball archive
changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: dd21ff5903f82bde9be205b7ffbff69895b2a6aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sripwoud commented 5 months ago

@cedoor that is not really related to that PR is it? Let's discuss here #110

cedoor commented 5 months ago

@cedoor that is not really related to that PR is it? Let's discuss here #110

Kind of, yes let's discuss this there!

sripwoud commented 5 months ago

In the end I am fixing #110 here too. I went with the solution of filtering 'latest' out from the list and ordering the versions in descending semantic order.

cedoor commented 5 months ago

In the end I am fixing #110 here too. I went with the solution of filtering 'latest' out from the list and ordering the versions in descending semantic order.

Makes sense 👍🏽