search

privacy-scaling-explorations / sonobe

Experimental folding schemes library
https://privacy-scaling-explorations.github.io/sonobe-docs/
MIT License
204 stars 53 forks source link

Implemented Mova folding scheme #161

Closed NiDimi closed 1 month ago

NiDimi commented 2 months ago

Added code for the Mova folding scheme (as specified in the https://eprint.iacr.org/2024/1220) into the list of the folding-schemes supported.

This PR addresses issue: #133

CPerezz commented 2 months ago

Aiming for a review next week. Would you be interested @arnaucube on reading the paper + reviewing this as a pair task? @dmpierre you're welcome too ofc!

arnaucube commented 2 months ago

@CPerezz sure, happy to do a call over it. I must say that this past weekend I went trough the paper to get ready to review this PR, was planning to do a first pass of review this week. But let's coordinate to comment it in a call too.

There is another thing, which may affect this PR, which is the refactor of the Arith traits that @winderica is doing in https://github.com/privacy-scaling-explorations/sonobe/pull/162 . Since #162 might be faster to review and unlocks other PRs that @winderica has in the pipeline, might get merged before this PR (#161), and might bring some git conflicts to it. But I think that the changes should not bring much trouble, since would be adapting the Mova code to do a similar thing than what the Nova update is doing in the #162.

CPerezz commented 2 months ago

Agree!! Let's unblock @winderica and refactor this accordingly then. That will also give me time to actually read the paper and be able to pair-review!

NiDimi commented 1 month ago

Feel free to let me know if you need any help from me.